[FFmpeg-devel] [PATCH 31/92] Vulkan patchset part 1 - common code changes
Lynne
dev at lynne.ee
Wed Mar 15 21:41:32 EET 2023
Mar 14, 2023, 12:51 by jamrial at gmail.com:
> On 3/14/2023 3:33 AM, Lynne wrote:
>
>> + for (int i = 0; i < 7; i++)
>> + s->cur_frame.ref_order_hint[i] =
>> + s->raw_frame_header->ref_order_hint[s->raw_frame_header->ref_frame_idx[i]];
>>
>
> Why do you need this in cur_frame? It's not a derived value, and the AV1RawFrameHeader struct is accessible in all AVHWaccel callbacks.
>
> And i think you should be looking at s->ref[s->raw_frame_header->ref_frame_idx[i]].raw_frame_header->order_hint instead, too, which is the decoder state vs the raw values in the current frame header (Although they should match in theory).
>
>> +
>> if (avctx->hwaccel && s->cur_frame.f->buf[0]) {
>> ret = avctx->hwaccel->start_frame(avctx, unit->data,
>>
Fixed, removed the commit altogether and just used the value directly.
Thanks for the review
More information about the ffmpeg-devel
mailing list