[FFmpeg-devel] [PATCH v3 5/7] avformat/matroskaenc: write a MaxBlockAdditionID element

[James Almer]

On 3/25/2023 8:39 AM, Michael Niedermayer wrote:
> On Fri, Mar 24, 2023 at 12:52:11PM -0300, James Almer wrote:
>> A non zero value is mandatory for Matroska if the track has blocks with BlockAdditions.
>>
>> Signed-off-by: James Almer <jamrial at gmail.com>
>> ---
>>   libavformat/matroskaenc.c                     | 39 +++++++++++++++++--
>>   tests/ref/fate/aac-autobsf-adtstoasc          |  4 +-
>>   tests/ref/fate/matroska-avoid-negative-ts     |  4 +-
>>   tests/ref/fate/matroska-dovi-write-config7    |  4 +-
>>   tests/ref/fate/matroska-dovi-write-config8    |  4 +-
>>   tests/ref/fate/matroska-dvbsub-remux          |  4 +-
>>   tests/ref/fate/matroska-encoding-delay        | 14 +++----
>>   tests/ref/fate/matroska-flac-extradata-update |  4 +-
>>   tests/ref/fate/matroska-h264-remux            |  4 +-
>>   .../fate/matroska-mastering-display-metadata  |  4 +-
>>   tests/ref/fate/matroska-move-cues-to-front    |  4 +-
>>   tests/ref/fate/matroska-mpegts-remux          |  4 +-
>>   tests/ref/fate/matroska-ms-mode               |  4 +-
>>   tests/ref/fate/matroska-ogg-opus-remux        | 10 ++---
>>   tests/ref/fate/matroska-opus-remux            | 10 ++---
>>   tests/ref/fate/matroska-pgs-remux             |  4 +-
>>   tests/ref/fate/matroska-pgs-remux-durations   |  4 +-
>>   tests/ref/fate/matroska-qt-mode               |  4 +-
>>   tests/ref/fate/matroska-spherical-mono-remux  |  4 +-
>>   tests/ref/fate/matroska-vp8-alpha-remux       |  4 +-
>>   tests/ref/fate/matroska-zero-length-block     |  4 +-
>>   tests/ref/fate/rgb24-mkv                      |  4 +-
>>   tests/ref/fate/shortest-sub                   |  4 +-
>>   tests/ref/lavf-fate/av1.mkv                   |  4 +-
>>   tests/ref/lavf/mka                            |  4 +-
>>   tests/ref/lavf/mkv                            |  4 +-
>>   tests/ref/lavf/mkv_attachment                 |  4 +-
>>   27 files changed, 98 insertions(+), 67 deletions(-)
> 
> breaks fate-seek-lavf-mkv

Yes, forgot to update that ref. Also for 6/7. Amended both locally.