[FFmpeg-devel] [PATCH] get_cabac_inline_x86: Don't inline if 32-bit Windows

Martin Storsjö martin at martin.st
Mon Mar 27 23:08:01 EEST 2023


On Mon, 27 Mar 2023, Christopher Degawa wrote:

> This may need to be re-done since according to
> https://trac.ffmpeg.org/ticket/8903,
> it seems to be affecting linux 32-bit as well with the latest compilers.

Oh, interesting - both me and Hendrik tried to reproduce it with 32 bit 
compilers for Linux today, but the combination that triggered it on 
Windows (-march=pentium4 -mtune=generic) didn't trigger it there.

With that in mind, I think it's rather clear that we should make this 
function noinline for all i386 combinations; yes it used to work back in 
the day, but compilers these days do way more things than they used to do, 
and inlineing this everywhere might not be feasible on i386.

// Martin



More information about the ffmpeg-devel mailing list