[FFmpeg-devel] [PATCH 1/2] lavc/vorbis_parser: quiet log on unrecognized packet types

[James Almer]

On 3/28/2023 5:32 PM, rcombs wrote:
> ---
>   libavcodec/vorbis_parser.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/libavcodec/vorbis_parser.c b/libavcodec/vorbis_parser.c
> index a7d15d4ce9..65ad3fe2a5 100644
> --- a/libavcodec/vorbis_parser.c
> +++ b/libavcodec/vorbis_parser.c
> @@ -234,7 +234,8 @@ int av_vorbis_parse_frame_flags(AVVorbisParseContext *s, const uint8_t *buf,
>               else if (buf[0] == 5)
>                   *flags |= VORBIS_FLAG_SETUP;
>               else
> -                goto bad_packet;
> +                av_log(s, AV_LOG_VERBOSE, "Ignoring packet with unknown type %i\n",
> +                       buf[0]);
>   
>               /* Special packets have no duration. */
>               return 0;

nit: commit message is wrong since you're not just logging, you're also 
now ignoring them instead of failing. So maybe "lavc/vorbis_parser: 
ignore unrecognized packet types".

LGTM otherwise.