[FFmpeg-devel] [PATCH 04/13] lavf: use AV_CODEC_PROP_FIELDS where appropriate

Michael Niedermayer michael at niedermayer.cc
Mon May 8 17:15:42 EEST 2023


On Sun, May 07, 2023 at 03:32:46PM +0200, Anton Khirnov wrote:
> H.264 and mpeg12 parsers need to be adjusted at the same time to stop
> using the value of AVCodecContext.ticks_per_frame, because it is not set
> correctly unless the codec has been opened. Previously this would result
> in both the parser and lavf seeing the same incorrect value, which would
> cancel out.
> Updating lavf and not the parsers would result in correct value in lavf,
> but the wrong one in parsers, which would break some tests.
> ---
>  libavcodec/h264_parser.c      |  4 ++--
>  libavcodec/mpegvideo_parser.c |  2 +-
>  libavformat/avformat.c        |  9 ++++++---
>  libavformat/demux.c           | 29 +++++++++++++++++++----------
>  libavformat/internal.h        |  3 +++
>  5 files changed, 31 insertions(+), 16 deletions(-)

Doesnt this sort of change need a major ABI bump ?
it sounds like lavc and lavf interdepend here both ways

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Elect your leaders based on what they did after the last election, not
based on what they say before an election.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20230508/e7cdb6a7/attachment.sig>


More information about the ffmpeg-devel mailing list