[FFmpeg-devel] [PATCH v2] lavfi/vf_libplacebo: add vulkan device import fallback

[Niklas Haas]

On Thu, 11 May 2023 11:53:55 +0200 Anton Khirnov <anton at khirnov.net> wrote:
> Quoting Niklas Haas (2023-05-11 10:39:02)
> > From: Niklas Haas <git at haasn.dev>
> > 
> > Recent versions of libplacebo have required Vulkan versions incompatible
> > with lavu Vulkan hwcontexts.
> 
> Why did that happen? Did something change in lavu that broke things?

No, upstream libplacebo dropped support, during a code refactor/simplification,
for contexts without various features that used to be optional. That refactor
is not yet in any tagged release, but it breaks current master+master building.

Easiest alternative fix available right now would be to merge the vulkan lavu
hwcontext changes that have been on ML for weeks (and gotten a LGTM from me).
Alternatively, I could try and back-port enabling of whatever extensions and
features are required onto the current Vulkan code.

I understand not wanting random filters to open hardware devices under the
hood, but I also think it's a bit silly to have to constantly synchronize
requirements between Ffmpeg and libplacebo like this. If both have such tight
requirements on device features and extensions, it makes more sense to me if
each takes care of their own respective device creation. Or maybe FFmpeg vulkan
could directly inspect `pl_vulkan_required_features` and enable whatever's
listed in there, for forward compatibility.