[FFmpeg-devel] [PATCH 55/97] Vulkan patchset part 2 - hwcontext rewrite and filtering

[Lynne]

May 11, 2023, 19:27 by anton at khirnov.net:

> Quoting Lynne (2023-05-11 19:20:45)
>
>> May 11, 2023, 18:40 by anton at khirnov.net:
>>
>> > Quoting Lynne (2023-04-24 17:56:38)
>> >
>> >> @@ -3685,8 +3547,9 @@ static int vulkan_map_from(AVHWFramesContext *hwfc, AVFrame *dst,
>> >>  #endif
>> >>  #endif
>> >>  default:
>> >> -        return vulkan_map_frame_to_mem(hwfc, dst, src, flags);
>> >> +        break;
>> >>
>> >
>> > This seems like it's also removing the ability to map to memory at all.
>> >
>>
>> It is. Due to the driver deciding the layout of multiplane images
>> (which are used by default), it's not spec-valid to map the memory
>> used. Rather than keeping complicated code which receives no
>> use at all, I decided to remove it.
>>
>
> That should be stated more clearly in the commit message then, along
> with the reason for dropping it.
>

Branch updated with all feedback.
The top unsquashed commits remains as-is because I need
to know whether "lavc/decode: allow to allocate hwaccel_priv_data early"
is okay, as the commits are cleanups which would make reverting
their squashing bug/time-consuming.