[FFmpeg-devel] [PATCH] avfilter/setpts: add command support

Stefano Sabatini stefasab at gmail.com
Sun May 14 12:14:38 EEST 2023


On date Wednesday 2023-05-10 00:12:52 +0100, Oleg Afanasyev wrote:
> On Sun, 7 May 2023 at 23:47, Stefano Sabatini <stefasab at gmail.com> wrote:
[...]
> >
> > what happens in case setpts->expr is freed and this fails?
> >
> > probably it should keep a reference to expr and remove it only in case
> > the new expression was successfully parsed
> 
> Fixed! Didn't realize that encoding continues even if command fails,
> so it was crashing with the previous expression still in place.
> 
> >
> > [...]
> >
> > Looks good to me otherwise.

Applied, thanks.


More information about the ffmpeg-devel mailing list