[FFmpeg-devel] [PATCH] Revert "avformat/hls: fail on probing non hls/m3u8 file extensions"
Anton Khirnov
anton at khirnov.net
Tue May 16 17:01:41 EEST 2023
Quoting Michael Niedermayer (2023-05-14 23:39:44)
> On Sun, May 14, 2023 at 09:41:29PM +0200, Anton Khirnov wrote:
> > This reverts commit 6b1f68ccb04d791f0250e05687c346a99ff47ea1, which
> > broke many streams in the wild
> >
> > Fixes #10353.
>
> This change violates a SHOULD in rfc8216 4. Playlists
>
> Each Playlist file MUST be identifiable either by the path component
> of its URI or by HTTP Content-Type. In the first case, the path MUST
> end with either .m3u8 or .m3u. In the second, the HTTP Content-Type
> MUST be "application/vnd.apple.mpegurl" or "audio/mpegurl".
>
> Clients SHOULD refuse to parse Playlists that are not so identified.
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> The commit message should mention the RFC and why it is not following the
> recommandition of not parsing such Playlists
It's been a longstanding project policy to try to process non-strictly
compliant files when possible.
And as I've said in the other thread (did not have time yet to reply
there, hopefully will soon), I don't think this is the place to enforce
such policies. The fact that you have to use NULL logging context is
by itself indicative of that.
--
Anton Khirnov
More information about the ffmpeg-devel
mailing list