[FFmpeg-devel] [PATCH 31/36] fftools/ffmpeg_dec: restructure audio/video decoding loop

[Michael Niedermayer]

On Wed, May 17, 2023 at 12:20:24PM +0200, Anton Khirnov wrote:
> It currently emulates the long-removed
> avcodec_decode_audio4/avcodec_decode_video2 APIs, which obfuscates the
> actual decoding flow. Restructure the decoding calls so that they
> naturally follow the new avcodec_send_packet()/avcodec_receive_frame()
> design.
> 
> This is not only significantly easier to read, but also shorter.

with this:
./ffmpeg -y -threads:a 1 -i tickets/1208/702121h264-TTA.mkvtest82.mkv -bitexact -vn file1208.mp3

Both before and afterwards the output is empty and we see

Finishing stream without any data written to it.
Output file is empty, nothing was encoded

after this patch while the output is not any better, now ffmpeg proclaims
success with its return code

just to be sure i try reading the output

[mp3 @ 0x5635bab17900] Format mp3 detected only with low score of 1, misdetection possible!
[mp3 @ 0x5635bab17900] Failed to read frame size: Could not seek to 1026.
[in#0 @ 0x5635bab177c0] Error opening input: Invalid argument

I dont think that convertion was successfull

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20230517/e26e6fec/attachment.sig>