[FFmpeg-devel] [PATCH] lavc/h264chroma: RISC-V V add motion compensation for 8x8 chroma blocks

Lynne dev at lynne.ee
Thu May 18 19:56:00 EEST 2023


May 18, 2023, 10:21 by arnie.chang at sifive.com:

> On Wed, May 17, 2023 at 10:54 PM Lynne <dev at lynne.ee> wrote:
>
>>
>> Finally, run:
>> make checkasm && ./tests/checkasm/checkasm --bench
>> and report on the timings for both the C and assembly versions.
>> If you've made a mistake somewhere, (forgot to restore stack, or a
>> callee-saved register,
>> or your function produces an incorrect result), checkasm will fail.
>>
>
> The checkasm does not cover motion compensation of chroma samples in the
> H.264 decoder,
> so my modification can not be tested.
>

I added one here http://ffmpeg.org/pipermail/ffmpeg-devel/2023-May/309812.html
follow the example and add a test next time.
I wouldn't accept risc-v asm without checkasm, the platform is too new (and doesn't
even have hardware yet), and probably prone to silicon issues.
We've found a few silicon bugs through checkasm over the years.



More information about the ffmpeg-devel mailing list