[FFmpeg-devel] [PATCH v2] avcodec/aacdec: add support for AAC SBR with 960 frame length

[Lynne]

May 20, 2023, 22:47 by dev at lynne.ee:

> May 20, 2023, 22:17 by matthias at walliczek.de:
>
>> Supports the european DAB+ digital radio coding
>>
>> Fixes: https://trac.ffmpeg.org/ticket/1407 "HE-AAC (v2): 960/120 MDCT window is not implemented"
>>
>> Co-developed-by: Lynne <dev at lynne.ee>
>> Signed-off-by: Matthias Walliczek <matthias at walliczek.de>
>> ---
>>  libavcodec/aacdec_template.c | 17 ++------------
>>  libavcodec/aacps.c           |  8 ++++---
>>  libavcodec/aacps.h           |  7 +++---
>>  libavcodec/aacps_common.c    |  3 ++-
>>  libavcodec/aacsbr_template.c | 43 +++++++++++++++++++++---------------
>>  libavcodec/sbr.h             |  2 +-
>>  6 files changed, 38 insertions(+), 42 deletions(-)
>>
>
> Patch is malformed, still missing stuff, and I was just about to post
> an updated version of mine.
> Let's not step on each other's toes and let me take over?
>

Patch may take slightly longer.
I'm having to make new versions of the DSP functions too,
and the QMF synthesis code is also wrong. It really is not as simple
as changing a few constants, which is why I put it off.
Keep in mind even if it sounds somewhat right, it's still
unacceptable - there is only a single valid way of decoding a file.