[FFmpeg-devel] [PATCH 03/14] vvcdec: add sps, pps, sh parser

[James Almer]

On 5/21/2023 10:03 AM, Nuo Mi wrote:
> ---
>   libavcodec/vvc/Makefile   |    4 +-
>   libavcodec/vvc/vvc_data.c | 3295 ++++++++++++++++++++++++++++++++++++
>   libavcodec/vvc/vvc_data.h |   69 +
>   libavcodec/vvc/vvc_ps.c   | 3379 +++++++++++++++++++++++++++++++++++++
>   libavcodec/vvc/vvc_ps.h   |  811 +++++++++
>   libavcodec/vvc/vvcdec.h   |    3 +
>   6 files changed, 7560 insertions(+), 1 deletion(-)
>   create mode 100644 libavcodec/vvc/vvc_data.c
>   create mode 100644 libavcodec/vvc/vvc_data.h
>   create mode 100644 libavcodec/vvc/vvc_ps.c
>   create mode 100644 libavcodec/vvc/vvc_ps.h

As mentioned on IRC, this should ideally use the already written CBS 
implementation of h266 instead of rewriting a second standalone 
implementation, removing code duplication and and preventing extra work 
in the future when extensions are added to the spec.

I'd like to hear Mark's opinion about this, too.