[FFmpeg-devel] [PATCH] avformat/gifdec: cleanup

[Paul B Mahol]

On 5/21/23, Michael Niedermayer <michael at niedermayer.cc> wrote:
> On Sun, May 21, 2023 at 01:24:06PM +0200, Paul B Mahol wrote:
>>  libavcodec/gifdec.c                    |   11 -
>>  libavformat/gifdec.c                   |  245 +++++------------------
>>  tests/ref/fate/gif-color               |  348
>> ++++++++++++++++-----------------
>>  tests/ref/fate/gif-deal                |  314
>> +++++++++++++++++++++++++++--
>>  tests/ref/fate/gif-disposal-background |   12 -
>>  tests/ref/fate/gif-disposal-restore    |    6
>>  tests/ref/fate/gifenc-bgr4_byte        |  348
>> ++++++++++++++++-----------------
>>  tests/ref/fate/gifenc-bgr8             |  348
>> ++++++++++++++++-----------------
>>  tests/ref/fate/gifenc-gray             |  348
>> ++++++++++++++++-----------------
>>  tests/ref/fate/gifenc-pal8             |  348
>> ++++++++++++++++-----------------
>>  tests/ref/fate/gifenc-rgb4_byte        |  348
>> ++++++++++++++++-----------------
>>  tests/ref/fate/gifenc-rgb8             |  348
>> ++++++++++++++++-----------------
>>  12 files changed, 1585 insertions(+), 1439 deletions(-)
>> a8f54d72293f55ac76ae2e004e57809d7e9b90c6
>> 0003-avformat-gifdec-switch-to-using-gif-parser.patch
>> From 866801d43a9cf4c90e86afde1963b8b684e92998 Mon Sep 17 00:00:00 2001
>> From: Paul B Mahol <onemda at gmail.com>
>> Date: Sat, 20 May 2023 14:13:27 +0200
>> Subject: [PATCH 3/3] avformat/gifdec: switch to using gif parser
>>
>> Update fate, more correct as timebase is not reduced.
>>
>> Signed-off-by: Paul B Mahol <onemda at gmail.com>
>> ---
>>  libavcodec/gifdec.c                    |  11 +-
>>  libavformat/gifdec.c                   | 245 +++++------------
>>  tests/ref/fate/gif-color               | 348 ++++++++++++-------------
>>  tests/ref/fate/gif-deal                | 314 ++++++++++++++++++++--
>>  tests/ref/fate/gif-disposal-background |  12 +-
>>  tests/ref/fate/gif-disposal-restore    |   6 +-
>>  tests/ref/fate/gifenc-bgr4_byte        | 348 ++++++++++++-------------
>>  tests/ref/fate/gifenc-bgr8             | 348 ++++++++++++-------------
>>  tests/ref/fate/gifenc-gray             | 348 ++++++++++++-------------
>>  tests/ref/fate/gifenc-pal8             | 348 ++++++++++++-------------
>>  tests/ref/fate/gifenc-rgb4_byte        | 348 ++++++++++++-------------
>>  tests/ref/fate/gifenc-rgb8             | 348 ++++++++++++-------------
>>  12 files changed, 1585 insertions(+), 1439 deletions(-)
>
> breaks:fate-fits-demux
> ...
> +0,        242,        242,        1,    14320, 0xa34e7331
> +0,        243,        243,        1,    14320, 0xa34e7331
> +0,        244,        244,        1,    14320, 0xa34e7331
> +0,        245,        245,        1,    14320, 0xa34e7331
> +0,        246,        246,        1,    14320, 0xa34e7331
> +0,        247,        247,        1,    14320, 0xa34e7331
> +0,        248,        248,        1,    14320, 0xa34e7331
> +0,        249,        249,        1,    14320, 0xa34e7331
> Test fits-demux failed. Look at tests/data/fate/fits-demux.err for details.
> tests/Makefile:307: recipe for target 'fate-fits-demux' failed
> make: *** [fate-fits-demux] Error 1
>
>

That is actually more correct output. Previously it would drop most of
the available frames.

> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Many that live deserve death. And some that die deserve life. Can you give
> it to them? Then do not be too eager to deal out death in judgement. For
> even the very wise cannot see all ends. -- Gandalf
>