[FFmpeg-devel] [PATCH] lavc/qsv: fallback to the default mfx implementation for internal session on Windows

[Xiang, Haihao]

On Ma, 2023-05-15 at 08:47 +0000, Xiang, Haihao wrote:
> On Ma, 2023-05-15 at 08:33 +0200, Hendrik Leppkes wrote:
> > On Mon, May 15, 2023 at 8:04 AM Xiang, Haihao
> > <haihao.xiang-at-intel.com at ffmpeg.org> wrote:
> > > 
> > > From: Haihao Xiang <haihao.xiang at intel.com>
> > > 
> > > The mfx implementation based on D3D11 is expected for an internal
> > > session on Windows, however sometimes this implemntation is not
> > > supported [1]. A fallback to the default mfx implementation is added in
> > > this patch.
> > > 
> > > [1] https://github.com/intel/cartwheel-ffmpeg/issues/246
> > > 
> > 
> > From the issue description, the user is trying to use it a as software
> > library, not a hardware one?
> 
> Yes, because the user has sw library only. 
> 
> > I don't think software fallback, especially an automatic one, is
> > really quite appropriate. When someone requests a "qsv" encoder, they
> > expect hardware.
> 
> It is not a software fallback. it is a fallback to the default one (which
> might
> be hw based or sw based, it is up to user's hw and media stack). 


I'll push this in a few days if there are no more comments.

Thanks
Haihao