[FFmpeg-devel] [PATCH] avformat/gifdec: cleanup

Michael Niedermayer michael at niedermayer.cc
Wed May 24 00:51:12 EEST 2023


On Mon, May 22, 2023 at 06:19:09PM +0200, Paul B Mahol wrote:
> On 5/21/23, Paul B Mahol <onemda at gmail.com> wrote:
> > Attached patches.
> >
> > This finally removes giant hacks in gif demuxer and allows using gif
> > files via pipe reliably.
> >
> 
> Hopefully final version.

[...]

>  libavcodec/gifdec.c      |   11 +-
>  libavformat/gifdec.c     |  244 +++++++++++------------------------------------
>  tests/ref/fate/gif-demux |    2 
>  3 files changed, 70 insertions(+), 187 deletions(-)
> 8624c021a27e9ac3d18db4e560179c3fe359953f  0002-avformat-gifdec-switch-to-using-gif-parser.patch
> From 899afe00bf969b8c47c6fb5afbde3a8f9be1536d Mon Sep 17 00:00:00 2001
> From: Paul B Mahol <onemda at gmail.com>
> Date: Sat, 20 May 2023 14:13:27 +0200
> Subject: [PATCH 2/2] avformat/gifdec: switch to using gif parser
> 
> Update fate test, more correct as last packet is not truncated.
> 
> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> ---
>  libavcodec/gifdec.c      |  11 +-
>  libavformat/gifdec.c     | 244 ++++++++++-----------------------------
>  tests/ref/fate/gif-demux |   2 +-
>  3 files changed, 70 insertions(+), 187 deletions(-)

seems to break resyncing

./ffmpeg -y  -f gif -i resync.gif -bitexact resync.nut

file at:
https://samples.ffmpeg.org/image-samples/GIF/resync.gif


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20230523/619e1281/attachment.sig>


More information about the ffmpeg-devel mailing list