[FFmpeg-devel] [PATCH 1/5] avformat/mov: We do not support creation times of 300 billion years ago

Michael Niedermayer michael at niedermayer.cc
Fri May 26 00:40:15 EEST 2023


Fixes: signed integer overflow: -9223372036854775808 - 2082844800 cannot be represented in type 'long'
Fixes: 58384/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-6428383700713472

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
---
 libavformat/mov.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/libavformat/mov.c b/libavformat/mov.c
index 9fdeef057e..3e2c4bc10d 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -1530,6 +1530,10 @@ static void mov_metadata_creation_time(MOVContext *c, AVIOContext *pb, AVDiction
         }
     }
     if (time) {
+        if (time < INT64_MIN + 2082844800) {
+            av_log(c->fc, AV_LOG_DEBUG, "creation_time predates big bang\n");
+            return;
+        }
         time -= 2082844800;  /* seconds between 1904-01-01 and Epoch */
 
         if ((int64_t)(time * 1000000ULL) / 1000000 != time) {
-- 
2.17.1



More information about the ffmpeg-devel mailing list