[FFmpeg-devel] [PATCH] doc/filtering: document some Vulkan filters

Lynne dev at lynne.ee
Mon May 29 02:38:04 EEST 2023


May 29, 2023, 00:57 by jamrial at gmail.com:

> On 5/28/2023 7:55 PM, Lynne wrote:
>
>> May 28, 2023, 17:54 by dev at lynne.ee:
>>
>>> This commit documents some of the Vulkan filters. Some of this was
>>> copy-pasted from equivalent OpenCL filters.
>>>
>>
>> Pushed alongside the Vulkan patchset.
>>
>
> Were all 100 patches reviewed and approved?
>

As far as I can tell.
Niklas has taken a look at them and given his LGTM.elenril reviewed all patches up to
and including the common video decoding code. 
There was an issue with internal_ref, but internal_ref
turned out to be unneeded. I had a "okay then" after
"any other hidden API changes" which I interpreted as
at least any public-side changes and code up to common
video decoding being good. What was left - the codec files
themselves, are not doing anything other than copying struct
values and calling the common video decoding functions.
The patchset has been here in various forms since February,
in a stable form since April, in its current form, minus
a few cleanups and documentation since last week, and in its
final form, since late Friday, with many calls for reviews.


More information about the ffmpeg-devel mailing list