[FFmpeg-devel] [PATCH] vulkan_decode: check if yuv_sampler exists before freeing it

Lynne dev at lynne.ee
Mon May 29 04:32:53 EEST 2023


May 29, 2023, 03:20 by philipl at overt.org:

> On Mon, 29 May 2023 02:22:34 +0200 (CEST)
> Lynne <dev at lynne.ee> wrote:
>
>> No Vulkan function is NULL-safe, for no real reason, despite
>> the language defining and returning VK_NULL_HANDLE.
>>
>> Patch attached.
>>
>
> Tested and works. I will note that both the function and s->hwctx are
> null in the failure case and if ctx->sampler could exist without those
> also being non-null, you could segfault again. I assume this won't
> happen in practice.
>
> ship it.
>

Pushed with a better description of what it fixes.


More information about the ffmpeg-devel mailing list