[FFmpeg-devel] [PATCH] vulkan_decode: do not align the image dimensions

Lynne dev at lynne.ee
Mon May 29 06:13:59 EEST 2023


May 29, 2023, 05:11 by philipl at overt.org:

> On Mon, 29 May 2023 04:08:17 +0200 (CEST)
> Lynne <dev at lynne.ee> wrote:
>
>> According to Dave Airlie:
>>
>> > <airlied> but I think ignoring it should be fine, I can't see any
>> > other way to get the imaeg extents correct for other usage
>> > <Lynne> what width/height should be used for the images?
>> > the final presentable dimensions, or the coded dimensions?
>> > <airlied> if you don't want noise I think the presentable dims
>> > <airlied> the driver should round up the allocations internally,
>> > but if you are going to sample from the images then w/h have to be
>> > the bounds of the image you want
>> > <airlied> since otherwise there's no way to stop the sampler from
>> > going outside the edges
>>
>
> Works fine on nvidia here. I agree with the logic - it doesn't seem
> reasonable to handle it the other way.
>

Confirmed it works on 5 different systems.
Pushed with an extended description.


More information about the ffmpeg-devel mailing list