[FFmpeg-devel] [PATCH v2] avcodec/cbs_vp8: Add support for VP8 codec bitstream READ methods

[Dai, Jianhui J]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of James
> Almer
> Sent: Monday, May 29, 2023 2:05 AM
> To: ffmpeg-devel at ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/cbs_vp8: Add support for VP8
> codec bitstream READ methods
> 
> On 5/23/2023 4:19 AM, Dai, Jianhui J wrote:
> > +typedef struct VP8RawFrameHeader {
> > +    // frame tag
> > +    uint8_t frame_type;
> > +    uint8_t profile;
> > +    uint8_t show_frame;
> > +    uint32_t first_partition_length_in_bytes;
> > +
> > +    uint32_t start_code_0;
> > +    uint32_t start_code_1;
> > +    uint32_t start_code_2;
> 
> These are unused since you read the values with fixed().

Thank for review. Done in PATCH v3.

> 
> > +    uint16_t horizontal_scale;
> 
> uint8_t for this one.
> 
> > +    uint16_t vertical_scale;
> 
> Same.

Done in PATCH v3.

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email ffmpeg-devel-request at ffmpeg.org
> with subject "unsubscribe".