[FFmpeg-devel] [PATCH 1/1] tools/general_assembly.pl - print names with emails

[Nicolas George]

Cosmin Stejerean via ffmpeg-devel (12023-11-03):
> Update GA script to print names in addition to emails since emails
> should not be shared in all contexts, this makes it easier to publish
> the current GA membership.
> 
> Signed-off-by: Cosmin Stejerean <cosmin at cosmin.at>
> ---
>  tools/general_assembly.pl | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/general_assembly.pl b/tools/general_assembly.pl
> index 898a6262ef..aa467ba34a 100644
> --- a/tools/general_assembly.pl
> +++ b/tools/general_assembly.pl
> @@ -7,6 +7,8 @@ use POSIX qw(strftime);
>  use Encode qw(decode);
>  use Data::Dumper;
>  
> +binmode(STDOUT, ":utf8");
> +
>  sub trim { my $s = shift; $s =~ s/^\s+|\s+$//g; return $s };
>  
>  my @shortlog = split /\n/, decode('UTF-8', `git log --pretty=format:"%aN <%aE>" --since="last 36 months" | sort | uniq -c | sort -r`, Encode::FB_CROAK);
> @@ -35,6 +37,7 @@ foreach my $line (@shortlog) {
>  }
>  
>  printf("# %s %s", strftime("%Y-%m-%d", localtime), decode('UTF-8', `git rev-parse HEAD`, Encode::FB_CROAK));

> -foreach my $email (sort values %assembly) {
> -    printf("%s\n", $email);
> +foreach my $name (sort keys %assembly) {

This is also changing the sort order. It might be acceptable but it
might also not be.

> +    my $email = $assembly{$name};
> +    printf("%s <%s>\n", $name, $email);
>  }

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20231103/e17bc1cd/attachment.sig>