[FFmpeg-devel] [PATCH] avfillter/buffersrc: activate and EOF fix

[Nicolas George]

Tristan Matthews (12023-11-02):
> Just to confirm that I can reproduce JEEB's test, before the patches:

Just to be clear: I never doubted that Paul's patches do make the bug go
away in your test case. That would imply accusing Paul of lying about
simple technical facts, that would be both stupid and uncivil.

What you need to understand is that is barely relevant: “I churned the
code a lot and now the bug does not happen in my test case” is not an
acceptable way of leading development.

What Paul needs to provide (or you, or anybody else; no idea who “JEEB”
is) is a proof that the changes are both correct and necessary.

Correct: you need to prove that this bug is fixed in all cases, not just
the one you were testing on.

Necessary: you need to establish that the bug cannot be fixed with fewer
changes, because each change is chance for introducing a new bug.

Such a proof would certainly start with with an analysis of how the bug
gets triggered by the current code.

The “necessary” point is especially important: it is a well-established
principle that filters with no more than one input and one output do not
need to use the activate framework directly (and therefore should not,
as it makes the code more complex).

If Paul thinks he found an exception to that well-established law, he
needs to present strong evidence.

But if no such exception exist (which is the most likely: the law is
true), then it is entirely possible that what Paul found is a bug in the
code that implements the activate mechanism for simple filters. And in
that case, we need to fix that bug.

Or maybe the actual problem is somewhere in the fftools an error check
is skipped.

We need to know what is happening before any fix can be devised. We need
an analysis of the bug. Any effort going into this that is not first
analyzing what is going on is a waste of time.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20231103/b78a3b47/attachment.sig>