[FFmpeg-devel] [PATCH] cherrypick ab7926341 into 4.2

Reed Weichler rweichler at gmail.com
Fri Nov 17 00:28:31 EET 2023


pretty self-explanatory.
i guess they forgot to cherrypick it when it was first committed.
here is my code to repro: https://pastebin.com/raw/yQr3WWvX
it needs a FLAC file as input.
it hit an EXC_BAD_ACCESS here:
https://github.com/FFmpeg/FFmpeg/blob/c6c36aa97a/libavformat/utils.c#L2227
index was equal to -1, so that code shouldnt even run, which usually means
undefined behavior
---
 libavformat/utils.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/utils.c b/libavformat/utils.c
index 4067d55fa1..2143d9fb59 100644
--- a/libavformat/utils.c
+++ b/libavformat/utils.c
@@ -2183,7 +2183,7 @@ int ff_seek_frame_binary(AVFormatContext *s, int
stream_index,
                          int64_t target_ts, int flags)
 {
     const AVInputFormat *avif = s->iformat;
-    int64_t av_uninit(pos_min), av_uninit(pos_max), pos, pos_limit;
+    int64_t pos_min = 0, pos_max = 0, pos, pos_limit;
     int64_t ts_min, ts_max, ts;
     int index;
     int64_t ret;
--
2.42.1


More information about the ffmpeg-devel mailing list