[FFmpeg-devel] [PATCH 05/13] fftools/ffmpeg_filter: move filtering to a separate thread

Michael Niedermayer michael at niedermayer.cc
Sat Nov 25 00:56:27 EET 2023


On Thu, Nov 23, 2023 at 08:15:00PM +0100, Anton Khirnov wrote:
> As previously for decoding, this is merely "scaffolding" for moving to a
> fully threaded architecture and does not yet make filtering truly
> parallel - the main thread will currently wait for the filtering thread
> to finish its work before continuing. That will change in future commits
> after encoders are also moved to threads and a thread-aware scheduler is
> added.
> ---
>  fftools/ffmpeg.h        |   9 +-
>  fftools/ffmpeg_dec.c    |  39 +-
>  fftools/ffmpeg_filter.c | 825 ++++++++++++++++++++++++++++++++++------
>  3 files changed, 730 insertions(+), 143 deletions(-)

This seems to cause a new assertion failure with this:

echo 'Call 0 ping'  | ./ffmpeg -nostats -i mm-short.mpg -vf nullsink,color=green -bitexact -vframes 1 -f null -

Press [q] to stop, [?] for help

Enter command: <target>|all <time>|-1 <command>[ <argument>]

Assertion !fgp->frame->buf[0] failed at fftools/ffmpeg_filter.c:2987
Aborted (core dumped)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Nations do behave wisely once they have exhausted all other alternatives. 
-- Abba Eban
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20231124/a1354286/attachment.sig>


More information about the ffmpeg-devel mailing list