[FFmpeg-devel] [PATCH v2] avcodec/amfenc: add smart access video option

[Mark Thompson]

On 23/11/2023 09:41, Evgeny Pavlov wrote:
> This commit adds option for enabling SmartAccess Video (SAV)
> in AMF encoders. SAV is an AMD hardware-specific feature which
> enables the parallelization of encode and decode streams across
> multiple Video Codec Engine (VCN) hardware instances.
> 
> Signed-off-by: Evgeny Pavlov <lucenticus at gmail.com>
> ---
>   libavcodec/amfenc.h      |  1 +
>   libavcodec/amfenc_av1.c  | 18 ++++++++++++++++++
>   libavcodec/amfenc_h264.c | 18 ++++++++++++++++++
>   libavcodec/amfenc_hevc.c | 18 ++++++++++++++++++
>   4 files changed, 55 insertions(+)

Can you explain a bit more about what this option actually does?  I can't find any details about it beyond nebulous "make things better", but presumably there is some tradeoff so you don't always enable it.

Some documentation explaining what it does and hinting when the user might want it on or off would be helpful (can be a separate patch).

Patch itself seems fine for a standalone option, though I would mildly prefer not to put meaningless marketing names in the code if it's possible to have a descriptive name instead.

Thanks,

- Mark