[FFmpeg-devel] [PATCH] lavc/hevcdsp_qpel_neon: using movi.16b instead of movi.2d

Martin Storsjö martin at martin.st
Tue Nov 28 15:57:50 EET 2023


Hi,

On Wed, 15 Nov 2023, xufuji456 via ffmpeg-devel wrote:

> Building iOS platform with arm64, the compiler has a warning: 
> "instruction movi.2d with immediate #0 may not function correctly on 
> this CPU, converting to movi.16b"

The change is correct and something we should do. However since 
fb1b88af77cd39034cef4b6d08af79496cd75ed8, our asm.S starts with an ".arch" 
directive, and that silences this warning, so I wonder how you've run into 
it or tested it. (I presume you've run into it with an older version, then 
tried to find all cases of this instruction in the codebase and changed 
those?)

(This warning is something that only is triggered when building for iOS, 
not macOS, due to a bug in early iPhone CPUs - see 
https://github.com/llvm/llvm-project/commit/9097a07e4e83b9f394598d53557247277b064b09.)

Anyway, the change looks good, so I'll push it.

// Martin



More information about the ffmpeg-devel mailing list