[FFmpeg-devel] [PATCH] avfilter: merge loudnorm filter functionality into f_ebur128.c

Anton Khirnov anton at khirnov.net
Thu Nov 30 15:57:30 EET 2023


Quoting Paul B Mahol (2023-11-30 15:01:23)
> On Thu, Nov 30, 2023 at 2:47 PM Anton Khirnov <anton at khirnov.net> wrote:
> 
> > Quoting Paul B Mahol (2023-11-30 13:48:16)
> > > On Thu, Nov 30, 2023 at 12:43 PM Anton Khirnov <anton at khirnov.net>
> > wrote:
> > >
> > > > Quoting Paul B Mahol (2023-11-28 17:51:14)
> > > > > Major change: loudnorm no longer returns oversampled audio at 192000
> > Hz
> > > > > when doing dynamic processing.
> > > > > Oversampled audio is only used for true peak finding now.
> > > > > This was trivial improvement as possible with ebur128 code.
> > > > > Minor changes: numerous stability fixes
> > > >
> > > > This patch in unreviewable and should be split.
> > > >
> > >
> > > It cant be split,
> >
> > Why not?
> >
> 
> Because it is new code and refactoring,

Then it should be first refactoring, then new code.

> and I know it enough that I'm confident to claim so.

Hubris usually implies more bugs.

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list