[FFmpeg-devel] [PATCH] avfilter: merge loudnorm filter functionality into f_ebur128.c

Kyle Swanson k at ylo.ph
Thu Nov 30 20:34:49 EET 2023


Hi,

On Thu, Nov 30, 2023 at 6:11 AM Paul B Mahol <onemda at gmail.com> wrote:
>
> I tested this a lot, and its great move forward.
>
> Make more useful testing and review next time, I'm sure you are quite
> capable person.

Paul, I agree with Anton. Refactoring the code (i.e. changing filter
behavior) and combining it with f_ebur128.c all at once makes the diff
very hard to review. I suggest an incremental approach, let's address
the issues you've identified with the loudnorm filter one by one, and
then a second stage where we see about combining with f_ebur128.c.

Thanks,
Kyle


More information about the ffmpeg-devel mailing list