[FFmpeg-devel] [PATCH] avcodec/h2645_parse: Avoid EAGAIN

[Michael Niedermayer]

On Sun, Oct 01, 2023 at 08:24:57PM +0200, Kieran Kunhya wrote:
> Sent from my mobile device
> 
> On Sun, 1 Oct 2023, 20:01 Michael Niedermayer, <michael at niedermayer.cc>
> wrote:
> 
> > EAGAIN causes an assertion failure when it is returned from the decoder
> >
> > Fixes: Assertion consumed != (-(11)) failed at libavcodec/decode.c:462
> > Fixes: assertion_IOT_instruction_decode_c_462/poc
> >
> > Found-by: Hardik Shah of Vehere (Dawn Treaders team)
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  libavcodec/h2645_parse.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavcodec/h2645_parse.h b/libavcodec/h2645_parse.h
> > index 787ce971ee4..128dea09efb 100644
> > --- a/libavcodec/h2645_parse.h
> > +++ b/libavcodec/h2645_parse.h
> > @@ -123,7 +123,7 @@ static inline int get_nalsize(int nal_length_size,
> > const uint8_t *buf,
> >
> >      if (*buf_index >= buf_size - nal_length_size) {
> >          // the end of the buffer is reached, refill it
> > -        return AVERROR(EAGAIN);
> > +        return AVERROR_INVALIDDATA;
> >      }
> >
> >      for (i = 0; i < nal_length_size; i++)
> > --
> > 2.17.1
> >
> 
> But these are not the same for an API user?

What public API returns this ? (and doesnt crash)
What public API documents this to be returned ?

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20231001/24c89f54/attachment.sig>