[FFmpeg-devel] [PATCH] libavformat/svs.c: Numeric Truncation in svs.c:57. Added a checker for valid sample_rate value.
mezhuevtp at ispras.ru
mezhuevtp at ispras.ru
Mon Oct 2 12:15:38 EEST 2023
From: headshog <craaaaaachind at gmail.com>
---
libavformat/svs.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/libavformat/svs.c b/libavformat/svs.c
index b91d29f5a6..bdfb856184 100644
--- a/libavformat/svs.c
+++ b/libavformat/svs.c
@@ -42,6 +42,7 @@ static int svs_read_header(AVFormatContext *s)
{
AVStream *st;
uint32_t pitch;
+ int64_t rescale_val;
st = avformat_new_stream(s, NULL);
if (!st)
@@ -51,10 +52,14 @@ static int svs_read_header(AVFormatContext *s)
pitch = avio_rl32(s->pb);
avio_skip(s->pb, 12);
+ rescale_val = av_rescale_rnd(pitch, 48000, 4096, AV_ROUND_INF);
+ if (rescale_val > INT_MAX)
+ return AVERROR(ERANGE);
+
st->codecpar->codec_type = AVMEDIA_TYPE_AUDIO;
st->codecpar->codec_id = AV_CODEC_ID_ADPCM_PSX;
st->codecpar->ch_layout = (AVChannelLayout)AV_CHANNEL_LAYOUT_STEREO;
- st->codecpar->sample_rate = av_rescale_rnd(pitch, 48000, 4096, AV_ROUND_INF);
+ st->codecpar->sample_rate = rescale_val;
st->codecpar->block_align = 32;
st->start_time = 0;
if (s->pb->seekable & AVIO_SEEKABLE_NORMAL)
--
2.25.1
More information about the ffmpeg-devel
mailing list