[FFmpeg-devel] [PATCH v1] avcodec/hevcpred_template: Removed unreachable code

Ronald S. Bultje rsbultje at gmail.com
Mon Oct 2 16:49:24 EEST 2023


Hi,

On Fri, Sep 29, 2023 at 4:32 AM Dawid Kozinski <d.kozinski at samsung.com>
wrote:

> Signed-off-by: Dawid Kozinski <d.kozinski at samsung.com>
> ---
>  libavcodec/hevcpred_template.c | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/libavcodec/hevcpred_template.c
> b/libavcodec/hevcpred_template.c
> index 16d1c7f35f..46bd806523 100644
> --- a/libavcodec/hevcpred_template.c
> +++ b/libavcodec/hevcpred_template.c
> @@ -213,13 +213,10 @@ do {                                  \
>                  j = 0;
>                  while (j < size_max_x && !IS_INTRA(j, -1))
>                      j++;
> -                if (j > 0)
> -                    if (cand_up_left) {
> -                        EXTEND_LEFT_CIP(top, j, j + 1);
> -                    } else {
> -                        EXTEND_LEFT_CIP(top, j, j);
> -                        top[-1] = top[0];
> -                    }
> +                if (j > 0) {
> +                    EXTEND_LEFT_CIP(top, j, j);
> +                    top[-1] = top[0];
> +                }
>                  left[-1] = top[-1];
>              }
>              left[-1] = top[-1];
> --
> 2.25.1
>

LGTM.

Can you merge yourself, or do you need me to merge for you?

Ronald


More information about the ffmpeg-devel mailing list