[FFmpeg-devel] [PATCH] aacdec: padding skip improvements

[Andreas Rheinhardt]

Lynne:
> The FFmpeg encoder will be modified to also output 2048 samples of
> padding at the start, to make it in line with other encoders.

Once again: What is the advantage? Doing what lots of other codecs do is
not a real advantage.

> 
> +    { "padding", "Override the padding at the start of a stream.\n",
> +        offsetof(AACContext, override_padding), AV_OPT_TYPE_INT, { .i64 = 2048 }, 1024, 8192, AACDEC_FLAGS },
> +

A decoder is supposed to decode and output what is given to it by
default and not trim it according to what you expect to be normal for
encoders for a given format. It is not even clear that there are any
padding samples at the start: The first packet to be fed to the decoder
could be from the middle of a file. In other words, the default value of
samples to discard should be zero.

Furthermore, the description is wrong, because this option itself might
be overridden by packet side data.

- Andreas