[FFmpeg-devel] [6.0] Segmentation fault in graph_parse() (was: [PATCH 2/2] fftools/ffmpeg_filter: initialize the) 'o' to silence the warning

[Dominik 'Rathann' Mierzejewski]

On Saturday, 25 February 2023 at 18:49, Thilo Borgmann wrote:
> Am 25.02.23 um 16:26 schrieb Jun Zhao:
> > From: Jun Zhao <barryjzhao at tencent.com>
> > 
> > silence the warning: variable 'o' is used uninitialized whenever
> > '&&' condition is false
> > 
> > Signed-off-by: Jun Zhao <barryjzhao at tencent.com>
> > ---
> >   fftools/ffmpeg_filter.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> LGTM.

Sorry to dig up an old thread, but this actually fixes a segmentation
fault when passing a non-existent filter option, so please make sure
it's back-ported to the next 6.0.x release.

To reproduce:
ffmpeg -y -f rawvideo -s 1x1 -i /dev/zero -vf palettegen=doesnt_exist=64 dummy.png

This was reported in RPM Fusion bugzilla:
https://bugzilla.rpmfusion.org/show_bug.cgi?id=6773

5.1.3 is not affected, only 6.0.

Regards,
Dominik
-- 
Fedora   https://fedoraproject.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
        -- from "Collected Sayings of Muad'Dib" by the Princess Irulan