[FFmpeg-devel] [PATCH] fate/screen: workaround test failure on mac M1

[Zhao Zhili]

> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Andreas Rheinhardt
> Sent: 2023年10月17日 1:41
> To: ffmpeg-devel at ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH] fate/screen: workaround test failure on mac M1
> 
> Zhao Zhili:
> > From: Zhao Zhili <zhilizhao at tencent.com>
> >
> > The last frame is corrupted. It has different results on different
> > platform.
> > ---
> >  tests/fate/screen.mak    | 3 ++-
> >  tests/ref/fate/zmbv-8bit | 1 -
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/fate/screen.mak b/tests/fate/screen.mak
> > index bd6d228544..1c92935d23 100644
> > --- a/tests/fate/screen.mak
> > +++ b/tests/fate/screen.mak
> > @@ -117,7 +117,8 @@ FATE_SCREEN += $(FATE_VMNC-yes)
> >  fate-vmnc: $(FATE_VMNC-yes)
> >
> >  FATE_ZMBV += fate-zmbv-8bit
> > -fate-zmbv-8bit: CMD = framecrc -i $(TARGET_SAMPLES)/zmbv/wc2_001-partial.avi -an -pix_fmt rgb24 -vf scale
> > +# The last frame is corrupted.
> > +fate-zmbv-8bit: CMD = framecrc -i $(TARGET_SAMPLES)/zmbv/wc2_001-partial.avi -an -frames:v 275 -pix_fmt rgb24 -vf scale
> >
> >  FATE_ZMBV += fate-zmbv-15bit
> >  fate-zmbv-15bit: CMD = framecrc -i $(TARGET_SAMPLES)/zmbv/zmbv_15bit.avi -pix_fmt rgb24 -t 25 -vf scale
> > diff --git a/tests/ref/fate/zmbv-8bit b/tests/ref/fate/zmbv-8bit
> > index 7c2fab691f..9a7c96cb32 100644
> > --- a/tests/ref/fate/zmbv-8bit
> > +++ b/tests/ref/fate/zmbv-8bit
> > @@ -278,4 +278,3 @@
> >  0,        272,        272,        1,   192000, 0xd08e49d1
> >  0,        273,        273,        1,   192000, 0xd08e49d1
> >  0,        274,        274,        1,   192000, 0xd08e49d1
> > -0,        275,        275,        1,   192000, 0x1f34135f
> 
> What code exactly leads to different outcomes for different systems?

I guess the difference comes from zlib decompress corrupted data.
Another patch for reference:
https://patchwork.ffmpeg.org/project/ffmpeg/patch/tencent_446495D6890EAEB36546930A084FD3FF1305@qq.com/

> 
> - Andreas
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".