[FFmpeg-devel] [PATCH 2/2] aacdec: padding skip improvements

[Lynne]

Oct 19, 2023, 10:40 by anton at khirnov.net:

> Quoting Lynne (2023-10-19 04:38:51)
>
>> @@ -3471,6 +3478,9 @@ static const AVOption options[] = {
>>  { "coded",    "order in which the channels are coded in the bitstream",
>>  0, AV_OPT_TYPE_CONST, { .i64 = CHANNEL_ORDER_CODED }, .flags = AACDEC_FLAGS, "channel_order" },
>>  
>> +    { "padding", "Override the padding at the start of a stream.\n",
>> +        offsetof(AACContext, override_padding), AV_OPT_TYPE_INT, { .i64 = 1024 }, 1024, 8192, AACDEC_FLAGS },
>>
>
> Why should this be a decoder option when the caller can already control
> it by inserting AV_PKT_DATA_SKIP_SAMPLES?
>

CLI, sadly, mainly.