[FFmpeg-devel] [PATCH] ffprobe: fix XML rendering, review XML layout

[Stefano Sabatini]

On date Wednesday 2023-10-18 23:44:45 +0200, Stefano Sabatini wrote:
> On date Tuesday 2023-10-17 11:56:35 +0200, Stefano Sabatini wrote:
> > On date Sunday 2023-10-15 19:15:16 +0200, Michael Niedermayer wrote:
> > > On Sat, Oct 14, 2023 at 09:50:24PM +0200, Stefano Sabatini wrote:
> > > > On date Saturday 2023-10-14 19:24:28 +0200, Stefano Sabatini wrote:
> > > > > Fix rendering of int values within a side data element, which was
> > > > > broken since commit d2d3a83ad93, where the side data element was
> > > > > correctly marked as a variable fields element. Logic to render a
> > > > > string variable was implemented already, but it was not implemented
> > > > > for the int fields path, which was enabled by that commit.
> > > > [...]
> > > > 
> > > > V2 with schema fixes.
> > > > 
> > > > I'd like to include the fixed version with 6.1 (will probably push in
> > > > a few days if I see no comments).
> > > 
> > > >  Changelog                  |    2 +
> > > >  doc/ffprobe.xsd            |   31 +++++++++++++++++++++-------
> > > >  fftools/ffprobe.c          |   49 +++++++++++++++++++++++++++++++++------------
> > > >  tests/ref/fate/ffprobe_xml |   26 +++++++++++++++--------
> > > 
> > > This needs to update fate references
> > 
> > Yes, thanks for noticing. Tested against complete FATE, updated.
> 
> Will push tomorrow or later if I see no more comments.

Pushed.