[FFmpeg-devel] [PATCH 3/3] avcodec/magicyuv: remove redundant check in inner loop

Michael Niedermayer michael at niedermayer.cc
Sun Oct 22 18:39:51 EEST 2023


Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
---
 libavcodec/magicyuv.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/libavcodec/magicyuv.c b/libavcodec/magicyuv.c
index d813f209203..3f6348b531e 100644
--- a/libavcodec/magicyuv.c
+++ b/libavcodec/magicyuv.c
@@ -125,10 +125,9 @@ static void magicyuv_median_pred16(uint16_t *dst, const uint16_t *src1,
     for (; CACHED_BITSTREAM_READER && x < width-c && get_bits_left(&gb) > 0;) {\
         ret = get_vlc_multi(&gb, (uint8_t *)dst + x * b, multi, \
                             vlc, vlc_bits, 3); \
-        if (ret > 0) \
-            x += ret; \
         if (ret <= 0) \
             return AVERROR_INVALIDDATA; \
+        x += ret; \
     } \
     for (; x < width && get_bits_left(&gb) > 0; x++) \
         dst[x] = get_vlc2(&gb, vlc, vlc_bits, 3); \
-- 
2.17.1



More information about the ffmpeg-devel mailing list