[FFmpeg-devel] [PATCH v4 1/3] lavc/libaribcaption.c: FIX: change all `boot` option var to `int`

Jan Ekström jeebjp at gmail.com
Sun Oct 29 10:46:04 EET 2023


On Tue, Oct 17, 2023 at 4:14 PM TADANO Tokumei <aimingoff at pc.nifty.jp> wrote:
>
> This patch fixes a bug in curret version.
>
> On some environments, a `bool` variable is small space than `int`.
> If a `bool` option was specified by command line, following
> variables would be filled and may be destroyed by av_opt_copy().
>
> This patch change all the `bool` option variables in
> `ARIBCaptionContext` to `int`.
>
> Signed-off-by: TADANO Tokumei <aimingoff at pc.nifty.jp>

Change LGTM. I changed the commit message to more match our guide
lines (no ".c" at the end, rephrased the commit message) in
https://github.com/jeeb/ffmpeg/commits/aribcaption_msz_patches_v3 .

Just tell me if you're OK with this and I'll pull it in.

Jan


More information about the ffmpeg-devel mailing list