[FFmpeg-devel] [PATCH] lavc/libx264: enable x4->params.analyse.b_fast_pskip if mb_info is set

[Carotti, Elias]

On Thu, 2023-08-31 at 19:09 +0200, Stefano Sabatini wrote:
> 
<snip>
> 
> > In particular why are you turning on fast_pskip silently based on a
> > completely different setting?
> 
> The patch is fixing the regression introduced by the unconditional
> setting of b_fast_pskip.
> 
> Now the question is if it makes sense to set mb_info without
> b_fast_pskip (in both case this should be probably documented).
> 
> @Elias can you comment about the mb_info/b_fast_pskip use case?

Sorry again for the delay in responding. 
We can safely remove it altogether. It's true we don't need to set it
along with mb_info.
However, it doesn't do any harm, since fast_pskip is by default set to
true by libx264 and only turned off either explicitly by the user, or
when using the placebo preset, or when doing lossless encoding 
(constant QP == 0.)
So, I agree, let's remove these three lines.
Elias




NICE SRL, viale Monte Grappa 3/5, 20124 Milano, Italia, Registro delle Imprese di Milano Monza Brianza Lodi REA n. 2096882, Capitale Sociale: 10.329,14 EUR i.v., Cod. Fisc. e P.IVA 01133050052, Societa con Socio Unico