[FFmpeg-devel] [PATCH v2 15/22] avformat/avio: Constify data pointees of write callbacks

[Anton Khirnov]

Quoting Andreas Rheinhardt (2023-09-07 03:05:31)
> They are currently non-const for reasons unknown, although
> avio_write() accepts a const buffer.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
> ---
> rtmpcrypt.c sometimes modifies the buffer whose content
> it is supposed to write.
> 
>  doc/APIchanges                   |  4 ++++
>  libavformat/avio.c               |  4 ++++
>  libavformat/avio.h               | 13 +++++++++++++
>  libavformat/avio_internal.h      |  4 ++++
>  libavformat/aviobuf.c            | 28 ++++++++++++++++++++++++++++
>  libavformat/hdsenc.c             |  4 ++++
>  libavformat/smoothstreamingenc.c |  4 ++++
>  libavformat/url.h                |  8 ++++++++
>  libavformat/version_major.h      |  1 +
>  9 files changed, 70 insertions(+)
> 
> diff --git a/doc/APIchanges b/doc/APIchanges
> index 762c2d6628..963ad477bf 100644
> --- a/doc/APIchanges
> +++ b/doc/APIchanges
> @@ -2,6 +2,10 @@ The last version increases of all libraries were on 2023-02-09
>  
>  API changes, most recent first:
>  
> +2023-09-07 - xxxxxxxxxx - lavf 60.xx.100 - avio.h
> +  Constify the buffer pointees in the write_packet and write_data_type
> +  callbacks of AVIOContext.

This implies that the change happens immediately, not that it's
scheduled for the next major version.

-- 
Anton Khirnov