[FFmpeg-devel] [PATCH v3 2/2] lavc/videotoolboxenc: Get the encoder supported properties

[mypopy at gmail.com]

On Fri, Sep 8, 2023 at 11:15 AM Marvin Scholz <epirat07 at gmail.com> wrote:
>
>
>
> On 8 Sep 2023, at 4:55, Jun Zhao wrote:
>
> > Get the encoder supported properties list, it will be used for
> > feature support checks.
> >
> > Signed-off-by: Jun Zhao <barryjzhao at tencent.com>
> > ---
> >  libavcodec/videotoolboxenc.c | 70 ++++++++++++++++++++++++------------
> >  1 file changed, 47 insertions(+), 23 deletions(-)
> >
> > diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
> > index 2e96990741..832147b6cd 100644
> > --- a/libavcodec/videotoolboxenc.c
> > +++ b/libavcodec/videotoolboxenc.c
> > @@ -232,6 +232,7 @@ typedef struct VTEncContext {
> >      AVClass *class;
> >      enum AVCodecID codec_id;
> >      VTCompressionSessionRef session;
> > +    CFDictionaryRef supported_props;
> >      CFStringRef ycbcr_matrix;
> >      CFStringRef color_primaries;
> >      CFStringRef transfer_function;
> > @@ -321,6 +322,34 @@ static void clear_frame_queue(VTEncContext *vtctx)
> >      set_async_error(vtctx, 0);
> >  }
> >
> > +static void vtenc_reset(VTEncContext *vtctx)
> > +{
> > +    if (vtctx->session) {
> > +        CFRelease(vtctx->session);
> > +        vtctx->session = NULL;
> > +    }
> > +
> > +    if (vtctx->supported_props) {
> > +        CFRelease(vtctx->supported_props);
> > +        vtctx->supported_props = NULL;
> > +    }
> > +
> > +    if (vtctx->color_primaries) {
> > +        CFRelease(vtctx->color_primaries);
> > +        vtctx->color_primaries = NULL;
> > +    }
> > +
> > +    if (vtctx->transfer_function) {
> > +        CFRelease(vtctx->transfer_function);
> > +        vtctx->transfer_function = NULL;
> > +    }
> > +
> > +    if (vtctx->ycbcr_matrix) {
> > +        CFRelease(vtctx->ycbcr_matrix);
> > +        vtctx->ycbcr_matrix = NULL;
> > +    }
> > +}
> > +
> >  static int vtenc_q_pop(VTEncContext *vtctx, bool wait, CMSampleBufferRef *buf, ExtraSEI **sei)
> >  {
> >      BufNode *info;
> > @@ -1110,6 +1139,20 @@ static int vtenc_create_encoder(AVCodecContext   *avctx,
> >          return AVERROR_EXTERNAL;
> >      }
> >
> > +    if (__builtin_available(macOS 10.13, iOS 11, tvOS 11, *)) {
>
> Thanks, though this needs the proper SDK guards as well too, to not break
> building with SDKs older than 10.13, unless FFmpeg does not care about this.
>
> See https://epir.at/2019/10/30/api-availability-and-target-conditionals/#checking-api-availability-at-compile-time
>
Thx the reference link, will add the build check