[FFmpeg-devel] [PATCH 03/21] avformat/aviobuf: Don't use incompatible function pointer type for call

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Sat Sep 9 12:25:47 EEST 2023


Tomas Härdin:
> tor 2023-09-07 klockan 02:32 +0200 skrev Andreas Rheinhardt:
>> It is undefined behaviour even in cases where it works
>> (it works because both are pointers). Instead change
>> the functions involved to use the type expected by the AVIO-API
>> and add inline wrappers for our internal callers.
>>
>> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
>> ---
>>  libavformat/avio.c    | 15 +++++++++++----
>>  libavformat/aviobuf.c |  6 ++----
>>  libavformat/url.h     | 20 ++++++++++++++++----
>>  3 files changed, 29 insertions(+), 12 deletions(-)
> 
> Should be OK. No version bump necessary since it's an internal API,
> right? And only within lavf as well
> 

That is correct; url.h is not even a public header.

- Andreas



More information about the ffmpeg-devel mailing list