[FFmpeg-devel] [PATCH 3/7] proresdec2: use VLC for level instead of EC switch

Christophe Gisquet christophe.gisquet at gmail.com
Sun Sep 10 18:56:34 EEST 2023


Hello

Le dim. 10 sept. 2023 à 17:40, Andreas Rheinhardt
<andreas.rheinhardt at outlook.com> a écrit :
> Another solution would be to use void* instead of GetBitContext* in the
> header and in the implementation and then convert this void* to
> GetBitContext* in the function.

The forward declaration will be enough.

> I do not know what you mean by "the encoder instead". What problem
> happens with the encoder? Why would the encoder include proresdec.h at
> all and why would it be affected by changes to the decoder?

The keyword was "faint", and it's a non-issue now. Just explaining why
I would have had that code change that now appears as an attempted fix
for videotoolbox, but really was never meant that way: pure luck, the
actual reason being lost to time.

-- 
Christophe


More information about the ffmpeg-devel mailing list