[FFmpeg-devel] [PATCH 1/2] avdevice/android_camera: fix missing include for usleep

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Sun Sep 17 11:48:25 EEST 2023


Zhao Zhili:
> From: Zhao Zhili <zhilizhao at tencent.com>
> 
> Signed-off-by: Zhao Zhili <zhilizhao at tencent.com>
> ---
>  libavdevice/android_camera.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/libavdevice/android_camera.c b/libavdevice/android_camera.c
> index 1934999c18..0425b27518 100644
> --- a/libavdevice/android_camera.c
> +++ b/libavdevice/android_camera.c
> @@ -25,6 +25,7 @@
>  #include <stdatomic.h>
>  #include <stdbool.h>
>  #include <stdint.h>
> +#include <unistd.h>
>  
>  #include <camera/NdkCameraDevice.h>
>  #include <camera/NdkCameraManager.h>

Sorry for having broken this in
ee485b4051c24e2cebe46b426294b346f0f5fff4. When creating this patch, I
just looked at what os_support.h directly provided (namely redefinitions
of lseek and fstat etc.) and checked what files used any of this. I
don't not check for indirect includes that are not redefined by
os_support.h. (And honestly, if something relies on indirect includes,
then that's the bug.)

- Andreas



More information about the ffmpeg-devel mailing list