[FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda
Timo Rothenpieler
timo at rothenpieler.org
Mon Sep 18 22:41:02 EEST 2023
On 18.09.2023 21:21, Marvin Scholz wrote:
>> enabled libvmaf && require_pkg_config libvmaf "libvmaf >= 2.0.0" libvmaf.h vmaf_init
>> +enabled libvmaf && require_pkg_config libvmaf_cuda "libvmaf >= 2.0.0" libvmaf_cuda.h vmaf_cuda_state_init
>> enabled libvo_amrwbenc && require libvo_amrwbenc vo-amrwbenc/enc_if.h E_IF_init -lvo-amrwbenc
>> enabled libvorbis && require_pkg_config libvorbis vorbis vorbis/codec.h vorbis_info_init &&
>> require_pkg_config libvorbisenc vorbisenc vorbis/vorbisenc.h vorbis_encode_init
>
> I am far from an expert with the configure script but won't that cause --enable-libvmaf to fail when
> libvmaf is built without cuda support? Which seems undesirable to me…
Yeah, hence my suggested change of
> enabled libvmaf_cuda && require_pkg_config libvmaf_cuda "libvmaf >= 2.0.0" libvmaf_cuda.h vmaf_cuda_state_init
As far as configure is concerned, those are two entirely separate
libraries, so they also need to be treated and tested as such.
More information about the ffmpeg-devel
mailing list