[FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

[Timo Rothenpieler]

On 25.09.2023 14:18, Kyle Swanson wrote:
> Hi,
> 
> On Sat, Sep 23, 2023 at 12:02 PM Timo Rothenpieler <timo at rothenpieler.org>
> wrote:
> 
>> On 23.09.2023 11:50, Kyle Swanson wrote:
>>> Hi,
>>>
>>> On Wed, Sep 20, 2023 at 11:55 PM Timo Rothenpieler <
>> timo at rothenpieler.org>
>>> wrote:
>>>> Or it needs to be a sub-feature of libvmaf, where if libvmaf is enabled,
>>>> support for CUDA is checked for, and then the vmaf_cuda filter needs to
>>>> depend on that check.
>>>
>>> This previous patch should do just that [0]. What's missing?
>>
>> The checks in there seem both overly complex and also not correct to me.
>> I've never seen a "*_filter" in a check_pkg_config or similar call.
>> With this setup, it'd be possible to call configure with
>> --enable-libvmaf, and have it success, even though there is no libvmaf
>> on the system, as long as the filter is disabled.
>>
>> If you want to go the implicit route, you'll want the following two things:
>>
>> For the dependencies
>>
>>   > libvmaf_cuda_filter_deps="libvmaf libvmaf_cuda ffnvcodec"
>>
>> And then at some point after the current "require_pkg_config libvmaf"
>> check:
>>
>>> enabled libvmaf && check_pkg_config libvmaf_cuda "libvmaf >= 2.0.0"
>> libvmaf_cuda.h vmaf_cuda_state_init
>>
>> I think there's a place in configure where a bunch of such optional
>> checks happen.
>> But I see no issue with throwing it right after the current libvmaf
>> check either.
>>
> 
> New patch attached.

lgtm

> Thanks,
> Kyle
> 
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".