[FFmpeg-devel] [PATCH] avcodec/photocd: allow decoding vlc with errors

[Anton Khirnov]

Quoting Paul B Mahol (2023-09-28 11:48:14)
> On 9/28/23, Anton Khirnov <anton at khirnov.net> wrote:
> > Quoting Paul B Mahol (2023-09-27 21:53:54)
> >> Attached.
> >>
> >> From 6b7e51e2b4facead9c45fb94647c85b58e6fdf22 Mon Sep 17 00:00:00 2001
> >> From: Paul B Mahol <onemda at gmail.com>
> >> Date: Wed, 27 Sep 2023 21:48:49 +0200
> >> Subject: [PATCH] avcodec/photocd: allow decoding vlc with errors
> >>
> >> Also rename option that no longer works.
> >> Also make tables finding more robust.
> >
> > Why do all these things in a single patch?
> >
> 
> I can boost my commits if you prefer that way.

Feel welcome.

> >> +            s->streampos = (AV_RB16(avpkt->data + 2048 + 1536 + 3) + 12)
> >> * 2048;
> >
> > Where do these magic numbers come from? Same below.
> 
> From offset from internal image file bitstream table structure.

Please describe that in a comment above that line then.

-- 
Anton Khirnov