[FFmpeg-devel] [PATCH 01/14] configure: Remove obsolete wmavoice->rdft, dct dependencies

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Fri Sep 29 01:11:53 EEST 2023


Lynne:
> Sep 28, 2023, 23:40 by andreas.rheinhardt at outlook.com:
> 
>> Andreas Rheinhardt:
>>
>>> Forgotten in a810126501e1ef0992d765720ff0d2629c5d1616.
>>>
>>> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
>>> ---
>>>  configure | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/configure b/configure
>>> index e1afcaa586..762311ae51 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -3033,7 +3033,7 @@ wmav1_decoder_select="sinewin wma_freqs"
>>>  wmav1_encoder_select="sinewin wma_freqs"
>>>  wmav2_decoder_select="sinewin wma_freqs"
>>>  wmav2_encoder_select="sinewin wma_freqs"
>>> -wmavoice_decoder_select="lsp rdft dct sinewin"
>>> +wmavoice_decoder_select="lsp sinewin"
>>>  wmv1_decoder_select="msmpeg4dec"
>>>  wmv1_encoder_select="msmpeg4enc"
>>>  wmv2_decoder_select="blockdsp error_resilience idctdsp intrax8 msmpeg4dec videodsp wmv2dsp"
>>>
>>
>> Unfortunately, patch #5 from this set (the main one) has been rejected
>> by the mailing list as spam. It is here:
>> https://github.com/mkver/FFmpeg/commit/e0ad224d4ccd293617c75a8ba6f5e2cda78b7c56
>> and a branch for these patches is here:
>> https://github.com/mkver/FFmpeg/commits/fft
>>
> 
> Would you mind awfully letting me be the author on this one? I already had a
> patch, but then I got swept up switching mpegaudiodsp to lavu/tx, doing
> a better 32-point DCT, and Cooley-Tukey, and VDD, and I forgot to send it.
> Would just be nice to see after working on lavu/tx for 4 years now.
> 

If you have a patch, why don't you send it now? There is really no need
for this code to be recompiled and relinked all the time.

> The rest of the configure changes, and the SILK change all LGTM.
> Can't comment on the rest, but I think they don't need to all be pushed
> at the same time.



More information about the ffmpeg-devel mailing list