[FFmpeg-devel] [PATCH] configure: disable vulkan if min version insufficient

[Hendrik Leppkes]

On Fri, Sep 29, 2023 at 3:55 PM Tristan Matthews <tmatth at videolan.org> wrote:
>
> Fixes: https://trac.ffmpeg.org/ticket/10596
> ---
>  configure | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 20db1801ed..50ba6f772f 100755
> --- a/configure
> +++ b/configure
> @@ -7154,7 +7154,8 @@ enabled crystalhd && check_lib crystalhd "stdint.h libcrystalhd/libcrystalhd_if.
>
>  if enabled vulkan; then
>      check_pkg_config_header_only vulkan "vulkan >= 1.3.255" "vulkan/vulkan.h" "defined VK_VERSION_1_3" ||
> -        check_cpp_condition vulkan "vulkan/vulkan.h" "defined(VK_VERSION_1_4) || (defined(VK_VERSION_1_3) && VK_HEADER_VERSION >= 255)"
> +        check_cpp_condition vulkan "vulkan/vulkan.h" "defined(VK_VERSION_1_4) || (defined(VK_VERSION_1_3) && VK_HEADER_VERSION >= 255)" ||
> +        warn "Disabling vulkan" && disable vulkan
>  fi
>

This change doesn't seem right. If a feature is explicitly requested,
we generally fail the build and don't just disable the feature
(afterall the user wanted it to be on). If the feature is not
explicitly requested, then it should not print a message.

- Hendrik